Fix bug with allowed symbols #5790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Youssef1313 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
mikadumont
approved these changes
Aug 28, 2020
|
|
|
@ktoliver I don't have permissions to create a revert here. Can you revert this change? |
|
@sharwell I created a revert PR. |
Thanks @Youssef1313. The replacement PR is merged. @sharwell Although there is a Revert button, the process it kicks off apparently is problematic, and we don't use it. The Microsoft Docs process to revert a merge is to create a replacement PR that contains the version you want to be live. |
|
CC @ghogen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/roslyn#47243
Needs review from Roslyn team.