Skip to content

missing from menu option #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2020
Merged

missing from menu option #6071

merged 2 commits into from
Dec 15, 2020

Conversation

surlydev
Copy link
Contributor

@surlydev surlydev commented Nov 6, 2020

added "Project" into menu text (also ellipses ... at end due to it opening a dialog)

added "Project" into menu text (also ellipses ... at end due to it opening a dialog)
@PRMerger12
Copy link
Contributor

@surlydev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TerryGLee
Copy link
Contributor

@surlydev Thanks for your PR; we appreciate it. Please note that I must edit it somewhat. If you view the markup of the content, you might note sections that have monikers on them, such as ::: moniker range="vs-2017" etc. What these do is make the content on a page work for the two most recent versions of the product, Visual Studio 2017 and Visual Studio 2019. The change you suggested is relevant only to Visual Studio 2019, so I must add the monikered markup so that the content can still serve two audiences. FYI.

Copy link
Contributor

@TerryGLee TerryGLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note my previous comment.

@ghost
Copy link

ghost commented Nov 13, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@TerryGLee TerryGLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the edits I made to account for monikered content that applies to both Visual Studio 2017 and Visual Studio 2019. (Note that monikerization works best when you repeat an entire procedure; enumeration can sometimes produce unexpected results when you try to moniker a single step.)

However, @surlydev, it looks like you might have to re-sign the CLA before we can process the change and then the PR.

@ktoliver
Copy link
Contributor

@surlydev - Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, we can merge the pull request. Thanks!

@PRMerger19 PRMerger19 requested a review from TerryGLee December 15, 2020 20:54
@PRMerger19
Copy link
Contributor

@TerryGLee : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver removed the request for review from TerryGLee December 15, 2020 21:07
@TerryGLee
Copy link
Contributor

#sign-off

@surlydev
Copy link
Contributor Author

@TerryGLee thank you for completing the editing with the additional moniker information, I wasn't fully aware, and will bear this in mind for future.

@ktoliver ktoliver merged commit db60d3f into MicrosoftDocs:master Dec 15, 2020
@surlydev surlydev deleted the patch-1 branch December 21, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants