Skip to content

Update the list of domains that should be whitelisted #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

keithrob
Copy link
Contributor

@keithrob keithrob commented Mar 13, 2018

Update the list of domainsthat should be whitelisted.

@keithrob keithrob changed the title Update install-and-use-visual-studio-behind-a-firewall-or-proxy-serve… Update the list of domains that should be whitelisted Mar 13, 2018
@opbld11
Copy link

opbld11 commented Mar 13, 2018

✅ Validation status: passed

File Status Preview URL Details
docs/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@TerryGLee TerryGLee self-assigned this Mar 14, 2018
@TerryGLee
Copy link
Contributor

@keithrob This is in tech review; FYI.

Copy link

@ikeras ikeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the installer uses these at all; are you thinking of the download of the actual bootstrapper (note: the section you're adding to is specific to the installation, the later section is around usage in the product)?

@opbldsb9
Copy link

✅ Validation status: passed

File Status Preview URL Details
docs/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbldsb1
Copy link

✅ Validation status: passed

File Status Preview URL Details
docs/install/install-and-use-visual-studio-behind-a-firewall-or-proxy-server.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@keithrob
Copy link
Contributor Author

@TerryGLee & @ikeras ,
Can you approve so that this can be merged?

@TerryGLee
Copy link
Contributor

@ikeras Thanks, Anson.

@TerryGLee
Copy link
Contributor

#sign-off

@TerryGLee TerryGLee merged commit f202c8b into MicrosoftDocs:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants