Skip to content

Correct the description of the command prompt #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SteveDunn
Copy link

No description provided.

@msftclas
Copy link

Hi @SteveDunn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


a. Add `--layout <path>`, where `<path>` is the location where you want the layout to download to. By default, all languages are downloaded. (See Example A.)
a. Add `--layout <path>`, where `<path>` is the location where you saved the exe in step 1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. But this piece isn't quite right, @SteveDunn: the layout path represents the location where the download will be cached. It doesn't have to be the location where you downloaded the initial setup executable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: the additional text about the editions...we appreciate your feedback, @SteveDunn. We'll take that under advisement and report back with next steps.

Copy link
Contributor

@TerryGLee TerryGLee Nov 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, @SteveDunn, we appreciate your input on the example text about all languages being downloaded. We will address that slightly differently than how you've suggested; I'll report back after the work is done. (At that point, we'll most likely close this merge request so that it doesn't conflict with other text changes that are in the queue.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveDunn - We're going to opt not to mention editions at this time, and we don't think it's a good idea to mention again that all languages are downloaded again in Step 2b, as that applies directly to Example A and therefore is mentioned in Step 2a. We thank you for submitting this PR, but we're closing it for now.

Copy link
Contributor

@timsneath timsneath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@TerryGLee TerryGLee closed this Dec 7, 2016
fenxu pushed a commit that referenced this pull request Aug 7, 2017
fenxu pushed a commit that referenced this pull request Apr 2, 2018
Deletion of old filename
fenxu pushed a commit that referenced this pull request Jul 16, 2018
fenxu pushed a commit that referenced this pull request Jul 16, 2018
gewarren pushed a commit that referenced this pull request Jan 9, 2019
gewarren pushed a commit that referenced this pull request Jul 15, 2019
ghogen pushed a commit that referenced this pull request Nov 10, 2020
learn-build-service-prod bot pushed a commit that referenced this pull request Dec 8, 2023
learn-build-service-prod bot pushed a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants