-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added step to open custom options page #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I found this step missing in newer versions of MSDN searches, so it's bothering me a bit, I'm hoping to add it here or somewhere else
Docs Build status updates of commit 1a3b1da:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/extensibility/creating-an-options-page.md | Details |
docs/extensibility/creating-an-options-page.md
- Line 289, Column 3: [Warning: hard-coded-locale - See documentation]
Link 'https://docs.microsoft.com/en-us/previous-versions/cc826083(v=vs.140)' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 289, Column 3: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://docs.microsoft.com/en-us/previous-versions/cc826083(v=vs.140)' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
@SIGEER2222 - review of your changes is pending until you sign the CLA. Thanks! #label:"aq-pr-triaged" |
@leslierichardson95 @SIGEER2222 |
Docs Build status updates of commit 21a101a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
It's always right to be careful
and thanks for the correction, I'm too careless hhh
…------------------ 原始邮件 ------------------
发件人: "MicrosoftDocs/visualstudio-docs" ***@***.***>;
发送时间: 2022年8月18日(星期四) 凌晨0:47
***@***.***>;
***@***.******@***.***>;
主题: Re: [MicrosoftDocs/visualstudio-docs] Added step to open custom options page (PR #8362)
@leslierichardson95 @SIGEER2222
Thanks for the submission. I reviewed and made changes for correctness, validation issues, and typos, etc., but @lelierichardson would need to review to confirm that this is a good idea. I don't know why this section was previously removed. If there was a good reason, there might be a problem with adding it back.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @leslierichardson95 |
@leslierichardson95 can you sign off please? thanks. |
#sign-off |
@SIGEER2222 - review of your changes is pending until you sign the CLA. It's all electronic and will take just a few minutes: https://cla.microsoft.com. Thanks! |
cycling pr to see if CLA updates |
Learn Build status updates of commit 21a101a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@jborsecnik Sorry to reply so late, I have already submitted a signature request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better version
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @leslierichardson95 |
I found this step missing in newer versions of MSDN searches, so it's bothering me a bit, I'm hoping to add it here or somewhere else