Skip to content

Added step to open custom options page #8362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

SIGEER2222
Copy link
Contributor

I found this step missing in newer versions of MSDN searches, so it's bothering me a bit, I'm hoping to add it here or somewhere else

I found this step missing in newer versions of MSDN searches, so it's bothering me a bit, I'm hoping to add it here or somewhere else
@ghost
Copy link

ghost commented Aug 15, 2022

CLA assistant check
All CLA requirements met.

@opbld30
Copy link

opbld30 commented Aug 15, 2022

Docs Build status updates of commit 1a3b1da:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/extensibility/creating-an-options-page.md ⚠️Warning Details

docs/extensibility/creating-an-options-page.md

  • Line 289, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/previous-versions/cc826083(v=vs.140)' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 289, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/previous-versions/cc826083(v=vs.140)' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Aug 15, 2022

@SIGEER2222 - review of your changes is pending until you sign the CLA. Thanks!

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Aug 15, 2022
@ghogen
Copy link
Collaborator

ghogen commented Aug 17, 2022

@leslierichardson95 @SIGEER2222
Thanks for the submission. I reviewed and made changes for correctness, validation issues, and typos, etc., but @leslierichardson95 would need to review to confirm that this is a good idea. I don't know why this section was previously removed. If there was a good reason, there might be a problem with adding it back.

@opbld32
Copy link

opbld32 commented Aug 17, 2022

Docs Build status updates of commit 21a101a:

✅ Validation status: passed

File Status Preview URL Details
docs/extensibility/creating-an-options-page.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@SIGEER2222
Copy link
Contributor Author

SIGEER2222 commented Aug 18, 2022 via email

@j-martens
Copy link
Collaborator

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @leslierichardson95

@j-martens
Copy link
Collaborator

@leslierichardson95 can you sign off please? thanks.

@leslierichardson95
Copy link
Collaborator

#sign-off

@jborsecnik
Copy link
Contributor

@SIGEER2222 - review of your changes is pending until you sign the CLA. It's all electronic and will take just a few minutes: https://cla.microsoft.com.

Thanks!

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 14, 2022

cycling pr to see if CLA updates

@opbld31
Copy link

opbld31 commented Oct 14, 2022

Learn Build status updates of commit 21a101a:

✅ Validation status: passed

File Status Preview URL Details
docs/extensibility/creating-an-options-page.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@SIGEER2222
Copy link
Contributor Author

@jborsecnik Sorry to reply so late, I have already submitted a signature request

Copy link
Contributor Author

@SIGEER2222 SIGEER2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better version

@j-martens
Copy link
Collaborator

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @leslierichardson95

@ghogen ghogen merged commit 0a1bdeb into MicrosoftDocs:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants