[desktop_drop]: Remove warnings, migrate macOS plugin to SPM, and regenerate example for web #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicajilau
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR improves build hygiene and modernizes plugin integration and examples by removing warnings, updating configurations, and migrating to SPM. Key changes include updating the macOS package configuration, regenerating the web example to remove deprecated scripts, and enhancing the macOS example with secure state restoration.
Reviewed Changes
Copilot reviewed 6 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/desktop_drop/macos/desktop_drop/Package.swift | New package file for the macOS plugin migrated to SPM with updated Swift tools version. |
| packages/desktop_drop/example/web/index.html | Updated web example by replacing outdated iOS meta tags and removing obsolete flutter scripts. |
| packages/desktop_drop/example/macos/Runner/AppDelegate.swift | Enhanced the macOS example by adding secure state restoration support. |
Files not reviewed (9)
- packages/desktop_drop/example/.metadata: Language not supported
- packages/desktop_drop/example/macos/Flutter/Flutter-Debug.xcconfig: Language not supported
- packages/desktop_drop/example/macos/Flutter/Flutter-Release.xcconfig: Language not supported
- packages/desktop_drop/example/macos/Podfile: Language not supported
- packages/desktop_drop/example/macos/Runner.xcodeproj/project.pbxproj: Language not supported
- packages/desktop_drop/example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme: Language not supported
- packages/desktop_drop/lib/src/channel.dart: Language not supported
- packages/desktop_drop/lib/src/drop_target.dart: Language not supported
- packages/desktop_drop/macos/desktop_drop/Sources/desktop_drop/PrivacyInfo.xcprivacy: Language not supported
Comments suppressed due to low confidence (1)
packages/desktop_drop/macos/desktop_drop/Package.swift:12
- [nitpick] Consider aligning the naming conventions between the library name and target name by using a consistent separator (either hyphen or underscore) to improve clarity.
.library(name: "desktop-drop", targets: ["desktop_drop"])
|
LGTM, thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crossle This PR includes several improvements and maintenance updates across the project:
I have tested this on web and macOS specially and everything works perfectly 🚀