This repository was archived by the owner on Jul 22, 2024. It is now read-only.
WebVRManager > Fix for #336 #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot being initialized. MozillaReality#336 + webvr.js is looking for an object named WebVRCameraSet to pass the messages to, but since it gets renamed in the instance method it won’t be found. This only occurs if the Instance method gets called before Awake. + Also added a debug message if you rename the object with the WebVRManager on it.
|
@Banyango Ah! I didn't quite catch why that was happening. Thanks so much for the fix! |
caseyyee
approved these changes
Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues some people were experiencing with the headset not functioning.