Skip to content

Commit 132374b

Browse files
authored
[CLEANUP] Avoid Hungarian notation in parseCharacter() (#965)
Part of #756
1 parent ee3d57c commit 132374b

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/Parsing/ParserState.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ public function parseCharacter($isForIdentifier)
170170
if (\preg_match('/[0-9a-fA-F]/Su', $this->peek()) === 0) {
171171
return $this->consume(1);
172172
}
173-
$sUnicode = $this->consumeExpression('/^[0-9a-fA-F]{1,6}/u', 6);
174-
if ($this->strlen($sUnicode) < 6) {
173+
$hexCodePoint = $this->consumeExpression('/^[0-9a-fA-F]{1,6}/u', 6);
174+
if ($this->strlen($hexCodePoint) < 6) {
175175
// Consume whitespace after incomplete unicode escape
176176
if (\preg_match('/\\s/isSu', $this->peek())) {
177177
if ($this->comes('\\r\\n')) {
@@ -181,13 +181,13 @@ public function parseCharacter($isForIdentifier)
181181
}
182182
}
183183
}
184-
$iUnicode = \intval($sUnicode, 16);
185-
$sUtf32 = '';
184+
$codePoint = \intval($hexCodePoint, 16);
185+
$utf32EncodedCharacter = '';
186186
for ($i = 0; $i < 4; ++$i) {
187-
$sUtf32 .= \chr($iUnicode & 0xff);
188-
$iUnicode = $iUnicode >> 8;
187+
$utf32EncodedCharacter .= \chr($codePoint & 0xff);
188+
$codePoint = $codePoint >> 8;
189189
}
190-
return \iconv('utf-32le', $this->charset, $sUtf32);
190+
return \iconv('utf-32le', $this->charset, $utf32EncodedCharacter);
191191
}
192192
if ($isForIdentifier) {
193193
$peek = \ord($this->peek());

0 commit comments

Comments
 (0)