Skip to content

[CLEANUP] Avoid Hungarian notation in parseCharacter() #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CLEANUP] Avoid Hungarian notation in parseCharacter() #965

merged 1 commit into from
Feb 20, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@oliverklee oliverklee requested a review from JakeQZ February 20, 2025 11:08
@oliverklee oliverklee self-assigned this Feb 20, 2025
@oliverklee
Copy link
Collaborator Author

I struggled with meaningful, correct variable names here and definitely would appreciate the second pair of eyes/hemispheres. 👀 🧠

@coveralls
Copy link

Coverage Status

coverage: 51.654%. remained the same
when pulling 879e546 on cleanup/hungarian/parse-character
into ee3d57c on main.

JakeQZ
JakeQZ approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good renames. I can understand this code much more easily now :)

@JakeQZ JakeQZ merged commit 132374b into main Feb 20, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/parse-character branch February 20, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ