[TASK] Drop greedy calculation of selector specificity #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/drop-greedy-specificity
branch
2 times, most recently
from
beea798 to
1ba847d
Compare
oliverklee
force-pushed
the
task/drop-greedy-specificity
branch
4 times, most recently
from
cd62676 to
8d91989
Compare
oliverklee
added a commit
that referenced
this pull request
Mar 1, 2025
This avoids additional state that makes it hard to compare selectors for equality. Also, this will improve performance for cases where the specificity is not needed (but will slightly worsen performance where the specificity is queried multiple times on the same selector instance). Closes #1021
oliverklee
added a commit
that referenced
this pull request
Mar 1, 2025
This avoids additional state that makes it hard to compare selectors for equality. Also, this will improve performance for cases where the specificity is not needed (but will slightly worsen performance where the specificity is queried multiple times on the same selector instance). Closes #1021
oliverklee
added a commit
that referenced
this pull request
Mar 1, 2025
This avoids additional state that makes it hard to compare selectors for equality. Also, this will improve performance for cases where the specificity is not needed (but will slightly worsen performance where the specificity is queried multiple times on the same selector instance). Closes #1021
oliverklee
force-pushed
the
task/drop-greedy-specificity
branch
from
8d91989 to
5674ca9
Compare
oliverklee
added a commit
that referenced
this pull request
Mar 2, 2025
This avoids additional state that makes it hard to compare selectors for equality. Also, this will improve performance for cases where the specificity is not needed (but will slightly worsen performance where the specificity is queried multiple times on the same selector instance). Closes #1021
This constructor parameter is not used, and having the specificity calculation always done lazily is not a problem.
oliverklee
force-pushed
the
task/drop-greedy-specificity
branch
from
5674ca9 to
34e1988
Compare
oliverklee
added a commit
that referenced
this pull request
Mar 2, 2025
This avoids additional state that makes it hard to compare selectors for equality. Also, this will improve performance for cases where the specificity is not needed (but will slightly worsen performance where the specificity is queried multiple times on the same selector instance). Closes #1021
JakeQZ
pushed a commit
that referenced
this pull request
Mar 3, 2025
This avoids additional state that makes it hard to compare selectors for equality. Also, this will improve performance for cases where the specificity is not needed. Closes #1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constructor parameter is not used, and having the specificity calculation always done lazily is not a problem.