-
Notifications
You must be signed in to change notification settings - Fork 144
[TASK] Add tests for the selector specificity #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2572d9a
to
bce6f45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a naming issue. MDN does indeed say:
In CSS, selectors are patterns used to match, or select, the elements you want to style...
"pattern" is a description of how they work. "selector" is the (official) name for what they are. I think the test names should reflect what the 'object' is called (or known as), rather than what it does or how it works.
Wittgenstein might disagree (if I sit on a table, it's now a chair), but he wasn't a computer scientist.
Also, I'd like this PR to be split for more manageable review - the addition of the deprecated test class can be done separately I think.
I'd like to find a way around that a selector can have a selector (which would mean that we need to deal with a selector's selector) … any ideas? |
The |
bce6f45
to
80fd492
Compare
Okay, then I'll keep using |
80fd492
to
7365d9b
Compare
Selector
7365d9b
to
b271be2
Compare
The other two PRs are merged so that now this PR is a lot smaller. Rebased, reworded and repushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in a test method name.
Specificites cannot be represented by a single number, so we should address that in future...
Co-authored-by: JakeQZ <[email protected]>
Added #1042 to capture this. |
Mostly move tests from
ParserTest
that belong intothe unit tests.
Part of #757
Part of #758