Skip to content

[CLEANUP] Improve some variable names in RuleSet #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

[CLEANUP] Improve some variable names in RuleSet #1039

merged 1 commit into from
Mar 3, 2025

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 28, 2025 •
edited
Loading

Part of #756.

@oliverklee oliverklee requested a review from JakeQZ February 28, 2025 21:35
@oliverklee oliverklee self-assigned this Feb 28, 2025
@coveralls
Copy link

coveralls commented Feb 28, 2025 •
edited
Loading

Coverage Status

coverage: 55.749% (-0.06%) from 55.808%
when pulling bbc8fc3 on cleanup/hungarian/property-or-rule-name
into 86aeaa7 on main.

@oliverklee oliverklee force-pushed the cleanup/hungarian/property-or-rule-name branch 4 times, most recently from 25b661b to f36699b Compare March 2, 2025 19:32
@oliverklee oliverklee marked this pull request as draft March 2, 2025 20:35
@oliverklee oliverklee removed the request for review from JakeQZ March 2, 2025 20:35
@oliverklee oliverklee force-pushed the cleanup/hungarian/property-or-rule-name branch from f36699b to bbc8fc3 Compare March 3, 2025 10:09
@oliverklee oliverklee changed the title [BUGFIX] Fix a type annotation in RuleSet [CLEANUP] Improve some variable names in RuleSet Mar 3, 2025
@oliverklee oliverklee removed the bug label Mar 3, 2025
@oliverklee oliverklee marked this pull request as ready for review March 3, 2025 10:10
@oliverklee oliverklee requested a review from JakeQZ March 3, 2025 10:11
@oliverklee oliverklee mentioned this pull request Mar 3, 2025
Merged
@JakeQZ JakeQZ merged commit 335a890 into main Mar 3, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/property-or-rule-name branch March 3, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ