[BUGFIX] Render rules in line and column number order #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
bugfix/rule-order-functional-without-parsing
branch
from
3332640 to
149d5ea
Compare
JakeQZ
requested changes
Mar 3, 2025
There was a problem hiding this comment.
This seems to work. I had overlooked a couple of things:
RuleSet::addRule()automatically sets the line number to one more than the previous highest, so they don't need setting explicitly;- The values can be simply set a strings, and don't need the creation of
Valueobjects.
If you change the PR number in the changelog, and review my other comment to double-check, I'd be happy for this to supersede #1058.
oliverklee
force-pushed
the
bugfix/rule-order-functional-without-parsing
branch
from
149d5ea to
5f2525d
Compare
JakeQZ
approved these changes
Mar 3, 2025
|
@JakeQZ Should we backport this? What do you think? |
Probably good to backport bugfixes of behavioural bugs, since 9,0 may be some time away... |
oliverklee
added a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1059.
oliverklee
added a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1059.
oliverklee
added a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1059.
oliverklee
added a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1059.
oliverklee
added a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1059.
JakeQZ
pushed a commit
that referenced
this pull request
Mar 4, 2025
This is the V8.x backport of #1059.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1052
Closes #1058