Skip to content

[CLEANUP] Avoid Hungarian notation in OutputFormat (part 2) #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[CLEANUP] Avoid Hungarian notation in OutputFormat (part 2) #1100

merged 1 commit into from
Mar 7, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@oliverklee oliverklee requested a review from JakeQZ March 6, 2025 17:22
@oliverklee oliverklee self-assigned this Mar 6, 2025
@oliverklee oliverklee removed the request for review from JakeQZ March 6, 2025 17:29
@oliverklee oliverklee marked this pull request as draft March 6, 2025 17:29
@oliverklee
Copy link
Collaborator Author

Sigh. This clashes with the magic in OutputFormat::set(). We'll need to deprecate and remove that function first.

@oliverklee
Copy link
Collaborator Author

oliverklee commented Mar 6, 2025 •
edited
Loading

And before that, we'll need to update the tests to no longer use set()/get(). (I might accidentally have ordered a can of worms.)

@oliverklee oliverklee force-pushed the cleanup/hungarian/format-2 branch from ecdfd90 to 3b591c6 Compare March 7, 2025 16:53
@coveralls
Copy link

Coverage Status

coverage: 55.037%. remained the same
when pulling 3b591c6 on cleanup/hungarian/format-2
into fff77eb on main.

@oliverklee oliverklee marked this pull request as ready for review March 7, 2025 17:04
@oliverklee oliverklee merged commit 67eb105 into main Mar 7, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/hungarian/format-2 branch March 7, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ