Skip to content

[CLEANUP] Fix some type annotations in ParserState #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2025
Merged

[CLEANUP] Fix some type annotations in ParserState #1130

merged 2 commits into from
Mar 9, 2025

Conversation

oliverklee
Copy link
Collaborator

Also make the parameter names non-Hungarian.

Part of #756

@oliverklee
[CLEANUP] Fix some type annotations in ParserState
918cace 
Also make the parameter names non-Hungarian.

Part of #756
@oliverklee oliverklee requested a review from JakeQZ March 9, 2025 08:47
@oliverklee oliverklee self-assigned this Mar 9, 2025
@coveralls
Copy link

coveralls commented Mar 9, 2025 •
edited
Loading

Coverage Status

coverage: 55.567%. remained the same
when pulling 151e015 on cleanup/hungarian/include-end
into b43388a on main.

@JakeQZ JakeQZ merged commit a8709e4 into main Mar 9, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/include-end branch March 9, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
bug cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ