[TASK] Mark OutputFormat as not extendable
#1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Mar 9, 2025
CHANGELOG.md
Outdated
Comment on lines
24
to
25
| - Mark `OutputFormat` as not extendable and the constructor as `@internal` | ||
| (#1131) |
There was a problem hiding this comment.
If my suggestion for the class DocBlock is accepted, this probably warrants a second changelog entry in the 'Deprecated' section. (But I don't think two separate PRs are needed!)
|
Also, I think these changes could be made directly on the 8.x branch only, because on |
oliverklee
added a commit
that referenced
this pull request
Mar 10, 2025
This is the V8.x backport of #1131.
oliverklee
added a commit
that referenced
this pull request
Mar 10, 2025
This is the V8.x backport of #1131.
Also mark the constructor as `@internal`.
Co-authored-by: JakeQZ <[email protected]>
Co-authored-by: JakeQZ <[email protected]>
oliverklee
force-pushed
the
task/non-extendable-of
branch
from
3430390 to
1368c3f
Compare
|
I have just created #1133 for the backport. As far as having this in |
JakeQZ
pushed a commit
that referenced
this pull request
Mar 10, 2025
This is the V8.x backport of #1131.
JakeQZ
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mark the constructor as
@internal.