Skip to content

[CLEANUP] Drop an unused internal constant #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

[CLEANUP] Drop an unused internal constant #1144

merged 1 commit into from
Mar 11, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee requested a review from JakeQZ March 11, 2025 22:50
@oliverklee oliverklee self-assigned this Mar 11, 2025
@coveralls
Copy link

Coverage Status

coverage: 55.567%. remained the same
when pulling 5f8e0cb on cleanup/drop-unused-constant
into 6e9d010 on main.

JakeQZ
JakeQZ approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may have been more of a documentary constant, just showing what the other at-rules are.

@JakeQZ JakeQZ merged commit 66718c1 into main Mar 11, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/drop-unused-constant branch March 11, 2025 23:06
@JakeQZ JakeQZ mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ