Skip to content

[TASK] Add native type declarations for atRuleName() #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

[TASK] Add native type declarations for atRuleName() #1145

merged 2 commits into from
Mar 12, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #811

@oliverklee oliverklee requested a review from JakeQZ March 11, 2025 22:59
@oliverklee oliverklee self-assigned this Mar 11, 2025
@coveralls
Copy link

coveralls commented Mar 11, 2025 •
edited
Loading

Coverage Status

coverage: 55.782%. remained the same
when pulling 14300c1 on task/types/atrulename
into 46da4b2 on main.

@oliverklee oliverklee force-pushed the task/types/atrulename branch from 367a64b to 6b581a0 Compare March 11, 2025 23:23
JakeQZ
JakeQZ reviewed Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think KeyFrame needs a constructor first. I'll do that now...

Other changes look fine (and could be a separate PR).

src/CSSList/KeyFrame.php Outdated
Comment on lines 10 to 13
/**
* Note: When constructing an instance of this class, `setVendorKeyFrame()` must be called directly after construction
* for the instance to be valid.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels messy to me. The same will apply to $animationName.

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 12, 2025 •
edited
Loading

I think KeyFrame needs a constructor first. I'll do that now...

#1146

I was about to commit a change adding a constructor, then realized that is not necessary - all that's needed is for the properties to have default non-empty-string values.

The above should take care of the changes in KeyFrame from this PR.

@oliverklee oliverklee force-pushed the task/types/atrulename branch from 6b581a0 to 14300c1 Compare March 12, 2025 08:09
@oliverklee oliverklee requested a review from JakeQZ March 12, 2025 08:09
@JakeQZ JakeQZ merged commit 6d934af into main Mar 12, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/types/atrulename branch March 12, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ