Skip to content

[TASK] Add native type declarations in Size #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

[TASK] Add native type declarations in Size #1162

merged 1 commit into from
Mar 13, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #811

@coveralls
Copy link

Coverage Status

coverage: 55.455%. remained the same
when pulling 98059f5 on task/types/size
into 34ebb96 on main.

@@ -125,9 +121,9 @@ public static function parse(ParserState $parserState, $isColorComponent = false
}

/**
* @return array<int, array<string, string>>
* @return array<int<1, max>, array<lowercase-string, non-empty-string>>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and precise.

@JakeQZ JakeQZ merged commit a05cb3b into main Mar 13, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/types/size branch March 13, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants