Skip to content

[CLEANUP] Make Commentable type annotations more specific #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Mar 16, 2025

Coverage Status

coverage: 55.906%. remained the same
when pulling f261869 on cleanup/commentable-phpdoc
into 4889353 on main.

@oliverklee oliverklee force-pushed the cleanup/commentable-phpdoc branch from a3ea98c to 439b76f Compare March 16, 2025 16:27
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the parameter of addComments be a list after #1173 is merged?

@oliverklee oliverklee force-pushed the cleanup/commentable-phpdoc branch from 439b76f to c5d968c Compare March 16, 2025 20:05
@oliverklee oliverklee requested a review from JakeQZ March 16, 2025 20:06
@JakeQZ JakeQZ merged commit dc3b9cb into main Mar 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/commentable-phpdoc branch March 16, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants