Keyframe selector validation #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues
======
+ Solved 1
- Added 3
See the complete overview on Codacy |
sabberworm
reviewed
Nov 12, 2019
| @@ -26,7 +28,7 @@ public function __construct($iLineNo = 0) { | |||
| $this->aSelectors = array(); | |||
| } | |||
|
|
|||
| public static function parse(ParserState $oParserState) { | |||
| public static function parse(ParserState $oParserState, $oList = NULL) { | |||
There was a problem hiding this comment.
sabberworm
reviewed
Nov 12, 2019
| @@ -97,7 +97,7 @@ private static function parseListItem(ParserState $oParserState, CSSList $oList) | |||
| } | |||
| } | |||
| } else { | |||
| return DeclarationBlock::parse($oParserState); | |||
| return DeclarationBlock::parse($oParserState, $oList); | |||
There was a problem hiding this comment.
sabberworm
reviewed
Nov 12, 2019
| } | ||
| $this->aSelectors[$iKey] = new Selector($mSelector); | ||
| } else { | ||
| if (!KeyframeSelector::isValid($mSelector)) { |
There was a problem hiding this comment.
sabberworm
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex for validating keyframe selectors should be slightly different to cover the "n%" part.