Remove tests and others from distribution #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to ship test in distribution builds
|
Can you elaborate on the benefits? Smaller file size? |
|
Yes, it’s a best practice to only ship production needed files. Php is used in many different environments where size matters like serverless. |
|
I didn’t know that composer respects git attributes so wohoo for that. But this will also affect ZIP file downloads from GitHub, won’t it? I’m not sure people expect test files to be missing when downloading a ZIP file of the repository. |
|
Only a release zip. If people download the code using the standard clone to zip feature. They will get it all. |
sabberworm
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.