Add a LICENSE file #210
Merged
Add a LICENSE file #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabberworm
reviewed
Apr 19, 2021
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
Do you think having the license in the README isn’t legally enforcible? In any case, I would assume having it only in one place is sufficient so if we have a separate file, please remove it from the README.
There was a problem hiding this comment.
I don't know about legals here. It's mostly about following established conventions, and about help GitHub (which can process LICENSE files, but not license sections in the README).
Will change.
There was a problem hiding this comment.
Updated and repushed.
oliverklee
force-pushed
the
task/license
branch
from
983e96f to
6414cb3
Compare
oliverklee
force-pushed
the
task/license
branch
from
6414cb3 to
d506753
Compare
sabberworm
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.