Add PHP linting to the CI build #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
feature/lint
branch
4 times, most recently
from
de67905 to
6abc48f
Compare
sabberworm
reviewed
Apr 23, 2021
| runs-on: ubuntu-20.04 | ||
| strategy: | ||
| matrix: | ||
| php-version: [ '5.3', '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4' ] |
There was a problem hiding this comment.
Is there some way to declare the php version list only once in the file?
There was a problem hiding this comment.
No, none that I'm currently aware of. (And unfortunately, GitHub Actions do not support YAML anchors yet.)
This ensures that the PHP files have valid syntax, and blocks the unit tests if there are any errors found.
oliverklee
force-pushed
the
feature/lint
branch
from
6abc48f to
e11b39a
Compare
sabberworm
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the PHP files have valid syntax, and blocks the unit
tests if there are any errors found.