Add static type analysis with PHPStan #227
Conversation
oliverklee
force-pushed
the
feature/phpstan
branch
2 times, most recently
from
2856cc0 to
a58fdcb
Compare
|
Marking as draft again. I think we should start with level 0 first (so that the baseline file is more manageable), and work our way up through the levels. I'd also like to add this to the CI build. |
Feel free to do this. Let the PR CI fail until all code is up to standards. |
Even better: With the baseline file, the build will pass with the code as-is, while we still prevent the introduction of new typing issues. Neat, isn't it? |
oliverklee
force-pushed
the
feature/phpstan
branch
23 times, most recently
from
c99f706 to
e4e3c47
Compare
oliverklee
force-pushed
the
feature/phpstan
branch
3 times, most recently
from
316a3a2 to
2b35cd4
Compare
| parameters: | ||
| ignoreErrors: | ||
| - | ||
| message: "#^Class Sabberworm\\\\CSS\\\\Parsing\\\\ParserState constructor invoked with 1 parameter, 2\\-3 required\\.$#" | ||
| count: 1 | ||
| path: lib/Sabberworm/CSS/CSSList/CSSList.php | ||
|
|
||
| - | ||
| message: "#^Access to an undefined property Sabberworm\\\\CSS\\\\Parsing\\\\ParserState\\:\\:\\$oParserHelper\\.$#" | ||
| count: 1 | ||
| path: lib/Sabberworm/CSS/Parsing/ParserState.php | ||
|
|
||
| - | ||
| message: "#^Access to an undefined property Sabberworm\\\\CSS\\\\Property\\\\Charset\\:\\:\\$aComments\\.$#" | ||
| count: 5 | ||
| path: lib/Sabberworm/CSS/Property/Charset.php | ||
|
|
||
| - | ||
| message: "#^Class PHPUnit\\\\Framework\\\\TestCase referenced with incorrect case\\: PHPunit\\\\Framework\\\\TestCase\\.$#" | ||
| count: 1 | ||
| path: tests/Sabberworm/CSS/OutputFormatTest.php | ||
|
|
||
| - | ||
| message: "#^Class PHPUnit\\\\Framework\\\\TestCase referenced with incorrect case\\: PHPunit\\\\Framework\\\\TestCase\\.$#" | ||
| count: 1 | ||
| path: tests/Sabberworm/CSS/ParserTest.php | ||
|
|
There was a problem hiding this comment.
Cool, I thought there’d be more
There was a problem hiding this comment.
That's also because we're starting at level 0. 😄 (The PHPStan levels go up to level 8 …)
phpstan.neon
Outdated
| @@ -0,0 +1,16 @@ | |||
| includes: | |||
There was a problem hiding this comment.
Should we name this phpstan.neon.dist as per https://phpstan.org/config-reference#config-file?
There was a problem hiding this comment.
Thanks! Changed, rebased and repushed.
oliverklee
force-pushed
the
feature/phpstan
branch
from
2b35cd4 to
81a63ad
Compare
Add Composer scripts for checking the code with PHPStan (while using a baseline) and for updating the baseline. When we fix PHPStan-reported issues (or update the PHPStan configuration), we can update the baseline bit by bit until all issues are fixed.
oliverklee
force-pushed
the
feature/phpstan
branch
from
81a63ad to
06044b9
Compare
Add Composer scripts for checking the code with PHPStan (while using
a baseline) and for updating the baseline.
When we fix PHPStan-reported issues (or update the PHPStan configuration),
we can update the baseline bit by bit until all issues are fixed.