Streamline the tests code style #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabberworm
reviewed
Jul 2, 2021
| 'php_unit_namespaced' => ['target' => '5.7'], | ||
| 'php_unit_set_up_tear_down_visibility' => true, | ||
| 'php_unit_test_annotation' => ['style' => 'annotation'], | ||
| 'php_unit_test_case_static_method_calls' => ['call_type' => 'self'], |
There was a problem hiding this comment.
Why not use
Suggested change
| 'php_unit_test_case_static_method_calls' => ['call_type' => 'self'], | |
| 'php_unit_test_case_static_method_calls' => ['call_type' => 'this'], |
and leave the assertions as-is?
I think most people are used to calling assertions using $this and it’s also what the phpunit documentation does.
There was a problem hiding this comment.
I talked to Sebastian Bergmann about this. He says calling the assert methods statically and non-statically both is valid (as PHP allows calling static methods non-statically), and it comes down to a matter of preference. He himself prefers the non-static calls because he likes doing calls statically only when this is technically necessary. I, on the other hand, prefer to keep things consistent: Always call static methods statically, and call non-static methods in a non-static way.
- calls the assert methods statically - use `@test` annotations instead of the `test` method name prefix Also add PHP CS Fixer rules to automate these changes.
oliverklee
force-pushed
the
cleanup/tests-formatting
branch
from
70105d2 to
2ff8961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@testannotations instead of thetestmethod name prefixAlso add PHP CS Fixer rules to automate these changes.