Polish the README #303
Merged
Polish the README #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabberworm
requested changes
Jul 2, 2021
| @@ -611,20 +661,30 @@ class Sabberworm\CSS\CSSList\Document#4 (2) { | |||
|
|
|||
| ## Contributors/Thanks to | |||
There was a problem hiding this comment.
I don’t like breaking up list items over multiple lines. Makes it hard to move them up or down in the editor (which is something I tend to do a lot more often with list items than with other paragraphs).
There was a problem hiding this comment.
Come to think of it, I also prefer to rely on the editor’s soft-wrap behaviour for paragraphs. But my opinions on that are not as strong as on list items.
There was a problem hiding this comment.
Rebased, changed and repushed.
- fix some typos - clean up the CSS and PHP examples - clean up the Markdown formatting - recommend `composer install` for installing
oliverklee
force-pushed
the
task/polish-readme
branch
from
40f83d7 to
8c4e4c5
Compare
sabberworm
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer installfor installing