Skip to content

[TASK] Move PHPStan from PHIVE to Composer #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

oliverklee
Copy link
Collaborator

This allows us to have PHPStan extensions, e.g., for PHPUnit.

@oliverklee oliverklee self-assigned this Feb 3, 2024
@oliverklee oliverklee marked this pull request as draft February 3, 2024 10:33
@oliverklee oliverklee force-pushed the task/phpstan-composer branch 3 times, most recently from 97d2294 to 15fe8ee Compare February 3, 2024 10:39
@oliverklee oliverklee marked this pull request as ready for review February 3, 2024 10:40
This allows us to have PHPStan extensions, e.g., for PHPUnit.
@oliverklee oliverklee force-pushed the task/phpstan-composer branch from 15fe8ee to 38838a1 Compare February 3, 2024 21:08
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, on Windows, I've found PHIVE to be a PHAFF, though perhaps not fully understood the point of using it. It seems simpler to me if we just use Composer.

@JakeQZ JakeQZ merged commit 2299296 into master Feb 4, 2024
@JakeQZ JakeQZ deleted the task/phpstan-composer branch February 4, 2024 01:41
@oliverklee
Copy link
Collaborator Author

Personally, on Windows, I've found PHIVE to be a PHAFF, though perhaps not fully understood the point of using it. It seems simpler to me if we just use Composer.

The point was to avoid (or get out of) dependency hell, i.e., being able to run PHPUnit (which requires a composer install) on newer PHP versions even if e.g., PHP-CS-Fixer does not install on that version yet. (And, in the past, the tools did not support the PHP version range that PHP-CSS-Parser support, i.e., from 5.x to 8.3.)

We can also go full-Composer now and switch back to PHIVE when we gave problems like described with a newer PHP version we want to support.

@JakeQZ
Copy link
Collaborator

JakeQZ commented Feb 5, 2024

We can also go full-Composer now and switch back to PHIVE when we gave problems like described with a newer PHP version we want to support.

No, let's stick with PHIVE for the reasons you've given. Thanks for jogging my memory re the reasons for using it. All I could remember were problems with updates and caches. IIRC this was mostly solved by removing the binaries from version control, then it was just an issue of getting the local config right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants