-
Notifications
You must be signed in to change notification settings - Fork 144
[TASK] Move PHPStan from PHIVE to Composer #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97d2294
to
15fe8ee
Compare
This allows us to have PHPStan extensions, e.g., for PHPUnit.
15fe8ee
to
38838a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, on Windows, I've found PHIVE to be a PHAFF, though perhaps not fully understood the point of using it. It seems simpler to me if we just use Composer.
The point was to avoid (or get out of) dependency hell, i.e., being able to run PHPUnit (which requires a We can also go full-Composer now and switch back to PHIVE when we gave problems like described with a newer PHP version we want to support. |
No, let's stick with PHIVE for the reasons you've given. Thanks for jogging my memory re the reasons for using it. All I could remember were problems with updates and caches. IIRC this was mostly solved by removing the binaries from version control, then it was just an issue of getting the local config right. |
This allows us to have PHPStan extensions, e.g., for PHPUnit.