Skip to content

[TASK] Make the data providers static #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[TASK] Make the data providers static #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/CSSList/AtRuleBlockListTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function implementsCommentable()
/**
* @return array<string, array<int, string>>
*/
public function mediaRuleDataProvider()
public static function mediaRuleDataProvider()
{
return [
'without spaces around arguments' => ['@media(min-width: 768px){.class{color:red}}'],
Expand Down
2 changes: 1 addition & 1 deletion tests/CSSList/DocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function getContentsInitiallyReturnsEmptyArray()
/**
* @return array<string, array<int, array<int, DeclarationBlock>>>
*/
public function contentsDataProvider()
public static function contentsDataProvider()
{
return [
'empty array' => [[]],
Expand Down
16 changes: 8 additions & 8 deletions tests/RuleSet/DeclarationBlockTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function expandBorderShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function expandBorderShorthandProvider()
public static function expandBorderShorthandProvider()
{
return [
['body{ border: 2px solid #000 }', 'body {border-width: 2px;border-style: solid;border-color: #000;}'],
Expand Down Expand Up @@ -66,7 +66,7 @@ public function expandFontShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function expandFontShorthandProvider()
public static function expandFontShorthandProvider()
{
return [
[
Expand Down Expand Up @@ -122,7 +122,7 @@ public function expandBackgroundShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function expandBackgroundShorthandProvider()
public static function expandBackgroundShorthandProvider()
{
return [
['body {border: 1px;}', 'body {border: 1px;}'],
Expand Down Expand Up @@ -175,7 +175,7 @@ public function expandDimensionsShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function expandDimensionsShorthandProvider()
public static function expandDimensionsShorthandProvider()
{
return [
['body {border: 1px;}', 'body {border: 1px;}'],
Expand Down Expand Up @@ -213,7 +213,7 @@ public function createBorderShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function createBorderShorthandProvider()
public static function createBorderShorthandProvider()
{
return [
['body {border-width: 2px;border-style: solid;border-color: #000;}', 'body {border: 2px solid #000;}'],
Expand Down Expand Up @@ -244,7 +244,7 @@ public function createFontShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function createFontShorthandProvider()
public static function createFontShorthandProvider()
{
return [
['body {font-size: 12px; font-family: serif}', 'body {font: 12px serif;}'],
Expand Down Expand Up @@ -287,7 +287,7 @@ public function createDimensionsShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function createDimensionsShorthandProvider()
public static function createDimensionsShorthandProvider()
{
return [
['body {border: 1px;}', 'body {border: 1px;}'],
Expand Down Expand Up @@ -325,7 +325,7 @@ public function createBackgroundShorthand($sCss, $sExpected)
/**
* @return array<int, array<int, string>>
*/
public function createBackgroundShorthandProvider()
public static function createBackgroundShorthandProvider()
{
return [
['body {border: 1px;}', 'body {border: 1px;}'],
Expand Down