Skip to content

[BUGFIX] Allow at-rules to be parsed in strict mode #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2024
Merged

[BUGFIX] Allow at-rules to be parsed in strict mode #475

merged 2 commits into from
Feb 14, 2024

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Feb 13, 2024

The reverts the change to CSSList in
134f4e6 and adds a comment that null is an expected return value when the end of the list (or block) is reached.

Fixes #352

@JakeQZ
[BUGFIX] Allow at-rules to be parsed in strict mode (#456)
b6213a6 
The reverts the change to `CSSList` in
134f4e6
and adds a comment that `null` is an expected return value when the end of
the list (or block) is reached.

Fixes #352
@JakeQZ JakeQZ added the bug label Feb 13, 2024
@JakeQZ JakeQZ self-assigned this Feb 13, 2024
@JakeQZ JakeQZ marked this pull request as draft February 13, 2024 23:56
@JakeQZ JakeQZ marked this pull request as ready for review February 14, 2024 00:03
@JakeQZ JakeQZ requested a review from oliverklee February 14, 2024 00:03
@oliverklee oliverklee merged commit ffd5a84 into v8.x Feb 14, 2024
@oliverklee oliverklee deleted the merge/456 branch February 14, 2024 07:46
@oliverklee oliverklee changed the title [BUGFIX] Allow at-rules to be parsed in strict mode (#456) [BUGFIX] Allow at-rules to be parsed in strict mode Feb 14, 2024
@oliverklee oliverklee added this to the 8.5.1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
bug
Projects
None yet
Milestone
8.5.1: Bug fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeQZ @oliverklee