[TASK] Add rector to composer.json with a simple null-config #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
requested changes
Jun 17, 2024
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
Adding rector as a development dependency enables us to do automatic refactorings. Initially this comes with a simple null-config, that does not do much but run rector, so following the suggested integration path of "taking it slow" [1]. Helps with MyIntervals#432 [1] https://getrector.com/documentation/integration-to-new-project Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
|
I addressed your comments, rebased onto the current main and force-pushed my changes. Please let me know if you would rather have fixup commits for later squashing them. |
oliverklee
requested changes
Jun 17, 2024
Yes, I'd prefer that as that makes re-reviewing a PR a bit easier. Thanks for asking! |
|
I addressed the last two comments regarding the Composer commands in a fixup commit. If you're done reviewing I can quash them. |
Thanks! There's no need, though - GitHub allows me to squash all commits of a PR when I merge it. |
oliverklee
requested changes
Jun 17, 2024
oliverklee
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding rector as a development dependency enables us to do automatic refactorings. Initially, this comes with a simple null-config, that does not do much but run rector, so following the suggested integration path of "taking it slow" [1].
Helps with #432
[1] https://getrector.com/documentation/integration-to-new-project