Skip to content

[CLEANUP] Fix indentation of dependabot configuration #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

ziegenberg
Copy link
Contributor

It was nothing fancy; It just calmed my inner Monk, who had been upset about the indentation :)

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this cleanup PR! 🙏

As far as I can see, this change contradicts the style conventions defined in our .editorconfig: https://github.com/MyIntervals/PHP-CSS-Parser/blob/main/.editorconfig#L11

Am I missing something here?

@ziegenberg
Copy link
Contributor Author

The rest of the file has two spaces of indentation. So it's inconsistent with itself. And the other *.yml files also use two spaces of indendation.

@ziegenberg
Copy link
Contributor Author

Anyway, I'm happy to go either way. :) Just trying to make it consistent

@oliverklee
Copy link
Collaborator

Then let's go with 4 spaces. Would you be willing to create a PR to bring the YAML files in line?

@ziegenberg
Copy link
Contributor Author

I'll amend this PR and file a separate one for the GitHub Actions *.yml files.

Rewrite file using the project style conventions of four spaces as
defined in `.editorconfig`.

Signed-off-by: Daniel Ziegenberg <[email protected]>
@ziegenberg ziegenberg force-pushed the indentation-dependabot branch from 2a4f3e3 to 3645c25 Compare June 17, 2024 13:42
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oliverklee oliverklee merged commit 0bdb389 into MyIntervals:main Jun 17, 2024
17 checks passed
@ziegenberg ziegenberg deleted the indentation-dependabot branch June 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants