[TASK] Add more PHP-CS-Fixer rules #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
task/more-fixer-rules
branch
5 times, most recently
from
a74eb08 to
be7de5d
Compare
oliverklee
changed the title
oliverklee
force-pushed
the
task/more-fixer-rules
branch
from
be7de5d to
4528686
Compare
|
Note: I'll need to add some type casts (in separate PRs) before we can make all files strict. |
Also drop some rules that are already in included in the used rulesets.
oliverklee
force-pushed
the
task/more-fixer-rules
branch
from
4528686 to
78361d0
Compare
JakeQZ
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Also drop some rules that are already in included in the used rulesets.
Actually, the rules being removed have the value being set as the default. So I'm wondering if they should be kept, to be explicit, or removed anyway, to avoid clutter.
Otherwise, this brings the config in line with the Emogrifier project, so we have consistency.
I don’t care much either way - as long as the config file is consistent between our two projects. :-) |
JakeQZ
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop some rules that are already in included in the used
rulesets.