Skip to content

[CLEANUP] Sort the types in union type PHPDoc annotations #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

[CLEANUP] Sort the types in union type PHPDoc annotations #638

merged 1 commit into from
Jul 2, 2024

Conversation

oliverklee
Copy link
Collaborator

This was done using the phpdoc_types_order PHP-CS-Fixer rule.

@oliverklee oliverklee requested review from sabberworm and JakeQZ July 2, 2024 08:10
@oliverklee oliverklee self-assigned this Jul 2, 2024
JakeQZ
JakeQZ reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done using the phpdoc_types_order PHP-CS-Fixer rule.

Is this with ['null_adjustment' => 'always_last', 'sort_algorithm' => 'none']?

@oliverklee
[CLEANUP] Sort the types in union type PHPDoc annotations
425b650 
This was done using the `phpdoc_types_order` PHP-CS-Fixer rule.
@oliverklee
Copy link
Collaborator Author

Is this with ['null_adjustment' => 'always_last', 'sort_algorithm' => 'none']?

Yes, exactly that.

JakeQZ
JakeQZ approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly that.

Thanks. I just wanted to confirm before approving.

@JakeQZ JakeQZ merged commit 991cab2 into main Jul 2, 2024
18 checks passed
@JakeQZ JakeQZ deleted the cleanup/fixer-4 branch July 2, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ