Skip to content

[TASK] Make all PHP files strict #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

[TASK] Make all PHP files strict #641

merged 1 commit into from
Aug 28, 2024

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Jul 4, 2024
@oliverklee oliverklee marked this pull request as draft July 4, 2024 07:27
@oliverklee oliverklee force-pushed the task/strict branch 2 times, most recently from c14e575 to d396bbf Compare August 28, 2024 22:07
@oliverklee oliverklee marked this pull request as ready for review August 28, 2024 22:09
JakeQZ
JakeQZ approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the required casts have been added in other changes.

@JakeQZ JakeQZ merged commit 8ccd0bb into main Aug 28, 2024
21 checks passed
@JakeQZ JakeQZ deleted the task/strict branch August 28, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ