[TASK] Avoid Hungarian notation in a testcase #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Super. Good nomenclature. Much easiser to understand now. Not so much because of the Hungarian notation, but because of the abbreviations ('doc') and imprecise naming ('declaration'). Longer variable names may take the parser a few nanoseconds more, but will save many orders of magnitude more than that for humans :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.