Add GitHub Action to Require Tests in Pull Requests #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathanael Esayeas <[email protected]>
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Thanks for contributing, @ghostwriter! 🙏 Looks generally good, but still needs a bit of polish. I've added some review comments in this regard.
Co-Authored-By: Oliver Klee <[email protected]>
oliverklee
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #729 by adding the infection/tests-checker-action GitHub Action that ensures tests are included in pull requests.
Changes Introduced:
.github/workflows/require-tests.yml: Added a workflow named 'Require Tests' that uses theinfection/tests-checker-actionto verify the presence of test files in thetestsdirectory with a specific pattern (*Test.php).