-
Notifications
You must be signed in to change notification settings - Fork 144
[FEATURE] Support rgba and rgb (etc.) being aliases #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't consider this a bug, because it wasn't a problem until CSS Color Module Level 4 came along. |
Another precursor to #755. |
Also, is this something to backport? |
If 9.0 is still some way off, then yes, but see below. This is mutlipart change. The key change to support space-separated arguments with a forward-slash separating the alpha argument is yet to come. It's an enhancement rather than a bugfix, but one that is needed sooner rather than later, since the CSS syntax has evolved. I noted in a recent backport that some syntaxes had to be changed to support PHP 5.6. OTOH, I recently saw a message from my hosting provider saying that if I wanted to continue using a PHP version below 8.0, I'd have to pay an additional premium. The current I think it would be more than reasonable to cut a 9.0 release fairly soon, regardless of not having completed all that we planned for it, and stop wasting time on the backports (focusing on something more interesting instead). |
As of CSS Color Module Level 4, `rgba` is an alias of `rgb`; likewise, `hsla` is an alias of `hsl`. This change allows any of the above color functions to contain either three or four arguments, with alpha assumed as the fourth, and allowed to be absent.
7814474
to
3f54b77
Compare
As of CSS Color Module Level 4,
rgba
is an alias ofrgb
; likewise,hsla
is an alias ofhsl
.This change allows any of the above color functions to contain either three or four arguments, with alpha assumed as the fourth, and allowed to be absent.