[CLEANUP] Split Color::parse into separate methods
#799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One for hex colors, and one for color functions. This reduces cyclomatic complexity on a per-method basis.
|
I'd recommend reviewing the changes with the 'hide whitespace' option enabled; otherwise it will look like there are a lot of changes, when in fact there aren't, because all that's happened is that the indentation has been decreased. (I don't know if there's a similar option for merging/rebasing, should it be needed.) |
JakeQZ
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
requested changes
Jan 23, 2025
oliverklee
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One for hex colors, and one for color functions.
This reduces cyclomatic complexity on a per-method basis.