Skip to content

[TASK] Remove Parser::setCharset/getCharset #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

oliverklee
Copy link
Collaborator

These methods were deprecated in version 8.7.0.

Fixes #687

@coveralls
Copy link

coveralls commented Jan 25, 2025

Coverage Status

coverage: 42.261% (+0.1%) from 42.138%
when pulling 6d12630 on task/drop-charset
into 129f7ce on main.

These methods were deprecated in version 8.7.0.

Fixes #687
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods were deprecated in version 8.7.0.

Indeed so.

@JakeQZ JakeQZ merged commit 90ca871 into main Jan 26, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/drop-charset branch January 26, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Parser::setCharset/getCharset
3 participants