[TASK] Add accessor tests for OutputFormat (part 1)
#847
Conversation
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
feature/output-format-accessors
branch
from
0063965 to
99fb6e4
Compare
oliverklee
changed the title
OutputFormatOutputFormat (part 1)
There was a problem hiding this comment.
Brilliant.
I tried experimentally ramping up PHPStan to level 2 and got loads of warnings re using the magic __call(). If we can resolve this and increase the PHPStan checking level, it will give us more confidence about future changes.
However, I think some of the test cases could be made more realistic.
tests/Unit/OutputFormatTest.php
Outdated
| */ | ||
| public function setStringQuotingTypeSetsStringQuotingType(): void | ||
| { | ||
| $value = 'x'; |
There was a problem hiding this comment.
I'd prefer a more realistic example here. Given the default is likely to be either " or ', how about `?
There was a problem hiding this comment.
Or maybe have a dataProvider to provide more than one quote type.
tests/Unit/OutputFormatTest.php
Outdated
| */ | ||
| public function setStringQuotingTypeProvidesFluentInterface(): void | ||
| { | ||
| self::assertSame($this->subject, $this->subject->setStringQuotingType('x')); |
tests/Unit/OutputFormatTest.php
Outdated
| */ | ||
| public function setSpaceAfterRuleNameSetsSpaceAfterRuleName(): void | ||
| { | ||
| $value = ' '; |
There was a problem hiding this comment.
Maybe a newline would be a more realistic example.
tests/Unit/OutputFormatTest.php
Outdated
| */ | ||
| public function setSpaceAfterRuleNameProvidesFluentInterface(): void | ||
| { | ||
| self::assertSame($this->subject, $this->subject->setSpaceAfterRuleName(' ')); |
The accessor tests are basically for two things:
Checking that different quote types work is out of scope - I see it more in scope of the tests for the CSS elements that use this particular property. |
oliverklee
force-pushed
the
feature/output-format-accessors
branch
from
99fb6e4 to
1867996
Compare
Currently, this class uses magic getters and setters. These should be proper methods instead. But first, we should have tests for the accessors. This is part 1.
oliverklee
force-pushed
the
feature/output-format-accessors
branch
from
1867996 to
f0b778f
Compare
Currently, this class uses magic getters and setters. These
should be proper methods instead.
But first, we should have tests for the accessors. This is
part 1.