Skip to content

[CLEANUP] Avoid Hungarian notation for aContents and items #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

[CLEANUP] Avoid Hungarian notation for aContents and items #854

merged 1 commit into from
Jan 30, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@oliverklee oliverklee self-assigned this Jan 30, 2025
@coveralls
Copy link

Coverage Status

coverage: 45.068%. remained the same
when pulling 934fd32 on cleanup/hungarian-content-items
into 3a147fd on main.

JakeQZ
JakeQZ approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$item is as good generally as anything I can think of, and matches the DocBlock comment in various cases $listItem also works where you've used it. Good renaming :)

@JakeQZ JakeQZ merged commit 24e69d4 into main Jan 30, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian-content-items branch January 30, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ