Skip to content

[CLEANUP] Add more type assertions in the tests #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

[CLEANUP] Add more type assertions in the tests #884

merged 1 commit into from
Feb 9, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Feb 8, 2025
@coveralls
Copy link

Coverage Status

coverage: 49.156%. remained the same
when pulling 343fc2b on cleanup/type-checks-in-tests
into cb3ae4b on main.

JakeQZ
JakeQZ approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the tests we can assert the type because it's what we're expecting given the input test data.

@JakeQZ JakeQZ merged commit d2d1db5 into main Feb 9, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/type-checks-in-tests branch February 9, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ