[TASK] Add more tests for OutputFormat
#893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
requested changes
Feb 10, 2025
tests/Unit/OutputFormatTest.php
Outdated
| /** | ||
| * @test | ||
| */ | ||
| public function createPrettyReturnsNewOutputFormatInstance(): void |
There was a problem hiding this comment.
I think "New" is redundant in the test method name, but it's consistent with createCompactReturnsNewOutputFormatInstance, which I signed off 🤷
| /** | ||
| * @test | ||
| */ | ||
| public function createPrettyCalledTwoTimesReturnsDifferentInstances(): void |
There was a problem hiding this comment.
I'm thinking (and agreeing) "TwoTimes" is better than "Twice" for non-native-English speaking coders.
| { | ||
| $newInstance = OutputFormat::createPretty(); | ||
|
|
||
| self::assertSame([',' => ' '], $newInstance->getSpaceAfterListArgumentSeparators()); |
There was a problem hiding this comment.
Should this just test that the key , has the value {space} - instead of the whole array?
There was a problem hiding this comment.
Or maybe the test method should be renamed to indicate it's checking the whole array by adding On;y at the end of its name.
Co-authored-by: JakeQZ <[email protected]>
|
Updated and repushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.