Skip to content

[CLEANUP] Avoid Hungarian notation for text/characters #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@coveralls
Copy link

coveralls commented Feb 16, 2025

Coverage Status

coverage: 50.801%. remained the same
when pulling 990e79b on cleanup/hungarian-text
into 8c770fb on main.

@oliverklee oliverklee force-pushed the cleanup/hungarian-text branch 2 times, most recently from 3740ca0 to 62408b5 Compare February 16, 2025 21:20
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think where it is $aText it is actually an array of possibly-multibyte characters (derived by splitting with an empty 'separator'). @sabberworm, would you be able to confirm this?

Much as I'd like a quaint reference to great literary works, I think this should be renamed to $characters, which also has a similar quirky literary metaphor.

@oliverklee oliverklee changed the title [CLEANUP] Avoid Hungarian notation for text/texts [CLEANUP] Avoid Hungarian notation for text/characters Feb 17, 2025
@oliverklee oliverklee force-pushed the cleanup/hungarian-text branch from 62408b5 to 90854b4 Compare February 17, 2025 18:08
@oliverklee oliverklee requested a review from JakeQZ February 17, 2025 18:08
@oliverklee oliverklee force-pushed the cleanup/hungarian-text branch from 90854b4 to 990e79b Compare February 17, 2025 18:18
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the substr method also confirms that the formerly-named $aText property is an array of (multibyte) characters.

@JakeQZ JakeQZ merged commit 1a385cd into main Feb 17, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian-text branch February 17, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants