Skip to content

[TASK] Add one more unit test for Document #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[TASK] Add one more unit test for Document #944

merged 1 commit into from
Feb 20, 2025

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 16, 2025 •
edited
Loading

Part of #757

@oliverklee oliverklee self-assigned this Feb 16, 2025
@oliverklee oliverklee marked this pull request as draft February 16, 2025 13:59
@coveralls
Copy link

coveralls commented Feb 16, 2025 •
edited
Loading

Coverage Status

coverage: 53.778%. remained the same
when pulling 83aaa05 on task/unit-tests/document
into 981464c on main.

@oliverklee oliverklee force-pushed the task/unit-tests/document branch 6 times, most recently from 7339f2f to 4ccb49f Compare February 20, 2025 10:23
@oliverklee oliverklee force-pushed the task/unit-tests/document branch from 4ccb49f to 83aaa05 Compare February 20, 2025 18:52
@oliverklee oliverklee changed the title [TASK] Add more unit tests for Document [TASK] Add one more unit test for Document Feb 20, 2025
@oliverklee oliverklee marked this pull request as ready for review February 20, 2025 18:52
@oliverklee oliverklee requested a review from JakeQZ February 20, 2025 18:52
JakeQZ
JakeQZ approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect you are already planning to add tests for this method in the derived classes :)

@JakeQZ JakeQZ merged commit f7532ed into main Feb 20, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/unit-tests/document branch February 20, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ