Skip to content

[CLEANUP] Ensure ParserState::strsplit() always returns array #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CLEANUP] Ensure ParserState::strsplit() always returns array #962

merged 1 commit into from
Feb 20, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Feb 20, 2025

... by throwing an exception on failure.

@JakeQZ
[CLEANUP] Ensure ParserState::strsplit() always returns array
d7b5283 
... by throwing an exception on failure.
@JakeQZ JakeQZ added the cleanup label Feb 20, 2025
@JakeQZ JakeQZ requested a review from oliverklee February 20, 2025 09:27
@JakeQZ JakeQZ self-assigned this Feb 20, 2025
@JakeQZ JakeQZ mentioned this pull request Feb 20, 2025
Merged
@coveralls
Copy link

Coverage Status

coverage: 51.281% (-0.05%) from 51.335%
when pulling d7b5283 on cleanup/strsplit
into 2be1044 on main.

@oliverklee oliverklee merged commit d6088b2 into main Feb 20, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/strsplit branch February 20, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee