Skip to content

document the buildtime environment variables #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 15, 2025
Merged

document the buildtime environment variables #374

merged 11 commits into from
Jan 15, 2025

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Jan 10, 2025 •
edited
Loading

close #106

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work ksimpson-work requested review from vzhurba01 and leofang and removed request for vzhurba01 January 10, 2025 17:48
ksimpson-work
ksimpson-work commented Jan 10, 2025
View reviewed changes
leofang
leofang requested changes Jan 12, 2025
View reviewed changes
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 12, 2025
@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do and removed P0 High priority - Must do! labels Jan 12, 2025
@ksimpson-work ksimpson-work marked this pull request as ready for review January 13, 2025 19:43
@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work ksimpson-work requested a review from leofang January 14, 2025 17:10
leofang
leofang requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the conflicts and merge!

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

suggested changes applied and conflicts resolved! thanks for the review

@leofang leofang enabled auto-merge January 15, 2025 16:26
@leofang
Copy link
Member

leofang commented Jan 15, 2025

thx, Keenan, auto-merge enabled

@leofang leofang merged commit 291ed64 into NVIDIA:main Jan 15, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

Assignees

@ksimpson-work ksimpson-work

Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P1 Medium priority - Should do
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.

Document all available build-time and run-time environment variables
2 participants
@ksimpson-work @leofang