Skip to content

Add a note about nvjitlink compatibility #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add a note about nvjitlink compatibility #390

merged 2 commits into from
Jan 15, 2025

Conversation

ksimpson-work
Copy link
Contributor

close #362

@ksimpson-work ksimpson-work added P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jan 13, 2025
@ksimpson-work ksimpson-work self-assigned this Jan 13, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

leofang
leofang reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Keenan! Could you also add a similar note on this to the 12.x.y binding release note? (We should also highlight that nvjitlink bindings are added, if we haven't done so already!)

@ksimpson-work
Copy link
Contributor Author

@leofang I just looked and it seems to be there already! Under highlights:
"- Add bindings for nvJitLink. It requires nvJitLink from CUDA 12.3 or above."

leofang
leofang approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's trigger the doc build.

@leofang
Copy link
Member

leofang commented Jan 13, 2025

/ok to test

@leofang
Copy link
Member

leofang commented Jan 14, 2025

/ok to test

@leofang leofang merged commit 09a1f5d into NVIDIA:main Jan 15, 2025
79 checks passed
@github-actions GitHub Actions
Copy link

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

@vzhurba01 vzhurba01 vzhurba01 approved these changes

Assignees

@ksimpson-work ksimpson-work

Labels
cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.

Document CTK version compatibility for nvJitLink
3 participants
@ksimpson-work @leofang @vzhurba01