Stop tracking cached files and Jupyter notebook hashes in doc builds #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
/ok to test |
2 similar comments
|
/ok to test |
|
/ok to test |
vzhurba01
force-pushed
the
351-trigger
branch
from
3bd7db0 to
532752e
Compare
|
/ok to test |
vzhurba01
changed the title
|
Labeling as blocked on #424. It builds off of a commit to notebook execution. |
|
/ok to test |
leofang
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Q: with #424, do we still need this change?
There was a problem hiding this comment.
We do because Jupyter notebook still generates new hashes for the jupytext and kernelspec for every commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #351
.doctreescontain cached build files and don't impact html rendering. Store them outside of html build path.overview.mdhas page settings that triggers Jupyter notebook execution. Since the settings have minimal impact on displayed page, remove them to avoid hash regeneration.